Fixing issues when puppet runs as service

manifests/unzip.pp

@@ -50,23 +50,35 @@
   $refreshonly      = false,
   $unless           = undef,
   $zipfile          = $name,
-  $provider         = 'powershell',
+  $provider         = 'dotnet',
   $options          = '20',
-  $command_template = 'windows/unzip.ps1.erb',
   $timeout          = 300,
+  $logoutput        = on_failure,
 ) {
   validate_absolute_path($destination)
 
   if (! $creates and ! $refreshonly and ! $unless){
     fail("Must set one of creates, refreshonly, or unless parameters.\n")
   }
 
+  unless( $provider == 'dotnet'  or $provider == 'com'){
+    fail("Wrong provider: `${provider}', choices are: dotnet or com!\n")
+  }
+
+  if ($provider ==  'dotnet'){
+    $command_template = 'windows/unzip_dotnet.ps1.erb'
+  }else{
+    $command_template = 'windows/unzip.ps1.erb'
+  }
+
+
   exec { "unzip-${name}":
     command     => template($command_template),
     creates     => $creates,
     refreshonly => $refreshonly,
     unless      => $unless,
-    provider    => $provider,
+    provider    => powershell,
     timeout     => $timeout,
+    logoutput   => $logoutput,
   }
 }

templates/unzip.ps1.erb

@@ -1,3 +1,22 @@
-$shell = New-Object -COMObject Shell.Application;
-$zipfile = $shell.NameSpace("<%= @zipfile %>");
-foreach($item in $zipfile.Items()){ $shell.NameSpace("<%= @destination %>").CopyHere($item, <%= @options %>) };
+$zipFile="<%= @zipfile %>"
+$dst="<%= @destination %>"
+
+if ( ! (Test-Path $zipfile) ) {
+    write-error "ZIP file does not exists: `$zipFile'"
+    exit 1
+}
+
+if ( ! (Test-Path $dst) ) {
+    write-error "Missing destination folder: `$dst'"
+    exit 1
+}
+
+try {
+    $shell = New-Object -COMObject Shell.Application;
+    $zipfile = $shell.NameSpace("<%= @zipfile %>");
+    foreach($item in $zipfile.Items()){ $shell.NameSpace("<%= @destination %>").CopyHere($item, <%= @options %>) };
+}
+catch {
+    write-error $_
+    exit 1
+}

templates/unzip_dotnet.ps1.erb

@@ -0,0 +1,21 @@
+$zipFile="<%= @zipfile %>"
+$dst="<%= @destination %>"
+
+if ( ! (Test-Path $zipfile) ) {
+    write-error "ZIP file does not exists: ``$zipFile'"
+    exit 1
+}
+
+if ( ! (Test-Path $dst) ) {
+    write-error "Missing destination folder: ``$dst'"
+    exit 1
+}
+
+try {
+    Add-Type -A System.IO.Compression.FileSystem
+    [IO.Compression.ZipFile]::ExtractToDirectory($zipFile, $dst)
+}
+catch {
+    write-error $_
+    exit 1
+}