feat(atomic): support highlights in atomic-product-description #4541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpbrault
requested review from
olamothe,
y-lakhdar,
louis-bompart and
fbeaudoincoveo
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
|
Created a separate component for the excerpt, and extracted a functional component, ExpandableText |
fbeaudoincoveo
requested changes
Oct 17, 2024
...mmerce/product-template-components/atomic-product-description/atomic-product-description.tsx
Show resolved
Hide resolved
packages/atomic/src/components/common/expandable-text/expandable-text.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/expandable-text/expandable-text.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/expandable-text/expandable-text.tsx
Outdated
Show resolved
Hide resolved
...nents/commerce/product-template-components/atomic-product-excerpt/atomic-product-excerpt.tsx
Outdated
Show resolved
Hide resolved
...nents/commerce/product-template-components/atomic-product-excerpt/atomic-product-excerpt.tsx
Show resolved
Hide resolved
packages/atomic/src/pages/examples/commerce-website/search.html
Outdated
Show resolved
Hide resolved
|
The description of this PR (support highlights in atomic-product-description ) has become a bit misleading :D |
This was referenced Oct 18, 2024
…nents/atomic-product-text/e2e/atomic-product-text.e2e.ts Co-authored-by: Alex Prudhomme <78121423+alexprudhomme@users.noreply.github.com>
…nents/atomic-product-excerpt/atomic-product-excerpt.tsx Co-authored-by: Frederic Beaudoin <fbeaudoin@coveo.com>
fpbrault
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
fpbrault
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
fpbrault
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
fbeaudoincoveo
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for highlights in atomic-product-description. Highlights are only supported when using the excerpt field.
https://coveord.atlassian.net/browse/KIT-3307