Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(atomic): fix script to scope E2E tests #4554

Merged
merged 5 commits into from
Oct 23, 2024
Merged

test(atomic): fix script to scope E2E tests #4554

merged 5 commits into from
Oct 23, 2024

Conversation

y-lakhdar
Copy link
Contributor

2 issues fixed:

  1. Incorrect Error Handling: When the script detects a file change from another package (e.g., headless/), it throws an error but does not set the testsToRun variable. This causes the CI to fail.
  2. False Positive Detection: The script incorrectly detects changes in headless-react as changes in headless, leading to the execution of all tests unnecessarily.

https://coveord.atlassian.net/browse/KIT-3667

Copy link

github-actions bot commented Oct 17, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.6 236.6 0
commerce 340.5 340.5 0
search 412 412 0
insight 400 400 0
recommendation 248.8 248.8 0
ssr 405.7 405.7 0
ssr-commerce 352.8 352.8 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@coveo/atomic@3.5.0
@coveo/atomic-react@3.1.7
@coveo/atomic-angular@3.1.7
@coveo/quantic@3.2.2

**/CHANGELOG.md
**/package.json
CHANGELOG.md
package.json
package-lock.json
@alexprudhomme alexprudhomme added this pull request to the merge queue Oct 23, 2024
Merged via the queue into master with commit 9ae81be Oct 23, 2024
93 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3667 branch October 23, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants