Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(atomic): fix script to scope E2E tests #4554

Merged
merged 5 commits into from
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/atomic-angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"@angular/platform-browser": "17.3.12",
"@angular/platform-browser-dynamic": "17.3.12",
"@angular/router": "17.3.12",
"@coveo/atomic": "3.4.0",
"@coveo/atomic": "3.5.0",
"rxjs": "7.8.1"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/atomic-angular/projects/atomic-angular/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@coveo/atomic-angular",
"version": "3.1.6",
"version": "3.1.7",
"license": "Apache-2.0",
"repository": {
"url": "https://github.com/coveo/ui-kit"
Expand All @@ -11,7 +11,7 @@
"@coveo/headless": "3.4.0"
},
"dependencies": {
"@coveo/atomic": "3.4.0",
"@coveo/atomic": "3.5.0",
"tslib": "2.6.3"
},
"engines": {
Expand Down
4 changes: 4 additions & 0 deletions packages/atomic-react/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## <small>3.1.7 (2024-10-18)</small>

- chore(deps): bump rollup (#4525) ([874286e](https://github.com/coveo/ui-kit/commits/874286e)), closes [#4525](https://github.com/coveo/ui-kit/issues/4525)

## <small>3.1.1 (2024-09-24)</small>

- docs: document headless, atomic, and atomic-react entry points (#4455) ([3853bdc](https://github.com/coveo/ui-kit/commits/3853bdc)), closes [#4455](https://github.com/coveo/ui-kit/issues/4455)
Expand Down
4 changes: 2 additions & 2 deletions packages/atomic-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@coveo/atomic-react",
"sideEffects": false,
"type": "module",
"version": "3.1.6",
"version": "3.1.7",
"description": "React specific wrapper for the Atomic component library",
"repository": {
"type": "git",
Expand Down Expand Up @@ -30,7 +30,7 @@
"commerce/"
],
"dependencies": {
"@coveo/atomic": "3.4.0"
"@coveo/atomic": "3.5.0"
},
"devDependencies": {
"@coveo/release": "1.0.0",
Expand Down
12 changes: 12 additions & 0 deletions packages/atomic/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
## 3.5.0 (2024-10-18)

- chore(deps): bump rollup (#4525) ([874286e](https://github.com/coveo/ui-kit/commits/874286e)), closes [#4525](https://github.com/coveo/ui-kit/issues/4525)
- fix(atomic): broken HTML because of formatting in CRGA markdown heading (#4522) ([9e15c6c](https://github.com/coveo/ui-kit/commits/9e15c6c)), closes [#4522](https://github.com/coveo/ui-kit/issues/4522) [/github.com/coveo/ui-kit/blob/master/packages/atomic/src/components/common/generated-answer/generated-content/markdown-utils.ts#L50](https://github.com//github.com/coveo/ui-kit/blob/master/packages/atomic/src/components/common/generated-answer/generated-content/markdown-utils.ts/issues/L50)
- fix(atomic): delete ./loader/package.json when building atomic (#4539) ([c39f716](https://github.com/coveo/ui-kit/commits/c39f716)), closes [#4539](https://github.com/coveo/ui-kit/issues/4539)
- fix(atomic): fix layout issue on product variants with imageSize set to none (#4521) ([cbfca7f](https://github.com/coveo/ui-kit/commits/cbfca7f)), closes [#4521](https://github.com/coveo/ui-kit/issues/4521)
- fix(atomic): prevent clicks on atomic-product-image indicators from opening the product page (#4534) ([4d53962](https://github.com/coveo/ui-kit/commits/4d53962)), closes [#4534](https://github.com/coveo/ui-kit/issues/4534)
- fix(atomic): prevent touch events on atomic-product-children from opening the product page (#4533) ([7739951](https://github.com/coveo/ui-kit/commits/7739951)), closes [#4533](https://github.com/coveo/ui-kit/issues/4533)
- fix(insight): error "getAllFacets is undefined" in insight panel interface (#4474) ([836ef3a](https://github.com/coveo/ui-kit/commits/836ef3a)), closes [#4474](https://github.com/coveo/ui-kit/issues/4474)
- feat(atomic): remove imageAltField as an array option & use image alt field prior to image not found ([ee7e1d9](https://github.com/coveo/ui-kit/commits/ee7e1d9)), closes [#4511](https://github.com/coveo/ui-kit/issues/4511)
- test(atomic): fix failing atomic-color-facet test because of source change (#4543) ([c423e15](https://github.com/coveo/ui-kit/commits/c423e15)), closes [#4543](https://github.com/coveo/ui-kit/issues/4543)

## 3.4.0 (2024-10-16)

- fix(atomic): add hover effect for atomic-product clickable element in mobile/grid (#4519) ([0828b1f](https://github.com/coveo/ui-kit/commits/0828b1f)), closes [#4519](https://github.com/coveo/ui-kit/issues/4519)
Expand Down
2 changes: 1 addition & 1 deletion packages/atomic/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@coveo/atomic",
"type": "module",
"version": "3.4.0",
"version": "3.5.0",
"description": "A web-component library for building modern UIs interfacing with the Coveo platform",
"homepage": "https://docs.coveo.com/en/atomic/latest/",
"repository": {
Expand Down
4 changes: 4 additions & 0 deletions packages/quantic/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## <small>3.2.2 (2024-10-18)</small>

- fix(atomic): broken HTML because of formatting in CRGA markdown heading (#4522) ([9e15c6c](https://github.com/coveo/ui-kit/commits/9e15c6c)), closes [#4522](https://github.com/coveo/ui-kit/issues/4522) [/github.com/coveo/ui-kit/blob/master/packages/atomic/src/components/common/generated-answer/generated-content/markdown-utils.ts#L50](https://github.com//github.com/coveo/ui-kit/blob/master/packages/atomic/src/components/common/generated-answer/generated-content/markdown-utils.ts/issues/L50)

## <small>3.2.1 (2024-10-16)</small>

- chore(quantic): skip consistently failing quantic tests (#4540) ([4a1b1f6](https://github.com/coveo/ui-kit/commits/4a1b1f6)), closes [#4540](https://github.com/coveo/ui-kit/issues/4540)
Expand Down
2 changes: 1 addition & 1 deletion packages/quantic/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@coveo/quantic",
"version": "3.2.1",
"version": "3.2.2",
"description": "A Salesforce Lightning Web Component (LWC) library for building modern UIs interfacing with the Coveo platform",
"author": "coveo.com",
"homepage": "https://coveo.com",
Expand Down
2 changes: 1 addition & 1 deletion packages/samples/angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@angular/platform-browser": "17.3.12",
"@angular/platform-browser-dynamic": "17.3.12",
"@angular/router": "17.3.12",
"@coveo/atomic-angular": "3.1.6",
"@coveo/atomic-angular": "3.1.7",
"rxjs": "7.8.1",
"tslib": "2.6.3",
"zone.js": "0.14.8"
Expand Down
4 changes: 2 additions & 2 deletions packages/samples/atomic-next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"private": true,
"type": "module",
"dependencies": {
"@coveo/atomic": "3.4.0",
"@coveo/atomic-react": "3.1.6",
"@coveo/atomic": "3.5.0",
"@coveo/atomic-react": "3.1.7",
"@coveo/headless": "3.4.0",
"next": "14.2.5",
"react": "18.3.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/samples/atomic-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"description": "Samples with atomic-react",
"private": true,
"dependencies": {
"@coveo/atomic": "3.4.0",
"@coveo/atomic-react": "3.1.6",
"@coveo/atomic": "3.5.0",
"@coveo/atomic-react": "3.1.7",
"@coveo/headless": "3.4.0",
"react": "18.3.1",
"react-dom": "18.3.1"
Expand Down
4 changes: 2 additions & 2 deletions packages/samples/iife/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
},
"dependencies": {
"@babel/standalone": "7.25.0",
"@coveo/atomic": "3.4.0",
"@coveo/atomic": "3.5.0",
"@coveo/atomic-hosted-page": "1.0.7",
"@coveo/atomic-react": "3.1.6",
"@coveo/atomic-react": "3.1.7",
"@coveo/headless": "3.4.0",
"react": "18.3.1",
"react-dom": "18.3.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/samples/stencil/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"e2e:watch": "cypress open --browser chrome --e2e"
},
"dependencies": {
"@coveo/atomic": "3.4.0",
"@coveo/atomic": "3.5.0",
"@coveo/bueno": "1.0.1",
"@coveo/headless": "3.4.0",
"@stencil/core": "4.20.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/samples/vuejs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"dependencies": {
"vue": "^3.4.15",
"@coveo/atomic": "3.4.0"
"@coveo/atomic": "3.5.0"
},
"devDependencies": {
"@vitejs/plugin-vue": "^5.0.3",
Expand Down
5 changes: 3 additions & 2 deletions scripts/ci/find-tests.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,12 @@ function determineTestFilesToRun(changedFiles, testDependencies) {

function ensureIsNotCoveoPackage(file) {
if (dependsOnCoveoPackage(file)) {
throw new Error('Change detected in an different Coveo package.');
throw new Error(`Change detected in an different Coveo package: ${file}`);
}
}

function dependsOnCoveoPackage(file) {
const externalPackages = ['packages/headless', 'packages/bueno'];
const externalPackages = ['packages/headless/', 'packages/bueno/'];
for (const pkg of externalPackages) {
if (file.includes(pkg)) {
return true;
Expand All @@ -122,4 +122,5 @@ try {
}
} catch (error) {
console.warn(error?.message || error);
setOutput(outputName, ''); // Passing an empty string will run all tests.
}
Loading