Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support executing queries from store #1511

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

paultranvan
Copy link
Contributor

We add a new option in the query API called executeFromStore. This is useful to allow the execution of a query directly on the store, i.e. without running on the link (StackLink or PouchLink), hence the database.

The use-case for this is to be able to have a very fast query when we have the relevant data on the store, typically after a sync. In such situation, we do not need to make a network call on the database as we can simply benefit from the local store.

@paultranvan paultranvan requested a review from zatteo July 30, 2024 14:53
@paultranvan paultranvan force-pushed the execute-from-store branch 3 times, most recently from 8d278ca to 951dd2a Compare July 30, 2024 16:14
We add a new option in the query API called `executeFromStore`.
This is useful to allow the execution of a query directly on the store,
i.e. without running on the link (StackLink or PouchLink), hence the
database.

The use-case for this is to be able to have a very fast query when we
have the relevant data on the store, typically after a sync. In such
situation, we do not need to make a network call on the database as we
can simply benefit from the local store.
Copy link
Contributor

@Crash-- Crash-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@Merkur39 Merkur39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@paultranvan paultranvan merged commit 49ac876 into master Jul 31, 2024
4 checks passed
@paultranvan paultranvan deleted the execute-from-store branch July 31, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants