fix: Support executing queries from store #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merkur39
force-pushed
the
fix/executeQueryFromState
branch
3 times, most recently
from
2651ce8
to
f334454
Compare
To avoid circular dependencies, it's best to move helpers from the `index` file to a new file and then export these functions to the index.
Merkur39
force-pushed
the
fix/executeQueryFromState
branch
from
f334454
to
458ca34
Compare
Merkur39
force-pushed
the
fix/executeQueryFromState
branch
from
458ca34
to
c368a21
Compare
Ldoppea
approved these changes
Aug 7, 2024
The `getCollectionFromSlice` helper expects an object
with doctypes as key.
However, the method `this.store.getState()` returns a
larger object such as
`{ cozy: { documents: { [doctype]: ... }, queries: {} }`.
In this case, the `client.getCollectionFromState` method
is more appropriate.
Merkur39
force-pushed
the
fix/executeQueryFromState
branch
from
c368a21
to
11a9c62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small correction to #1511