Improve translations for geolocation #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{backgroundPermissionOptionLabel} variable is interpolated by react-native-background-geolocation
zatteo
force-pushed
the
feat/improve-translations-geolocation
branch
from
c028712 to
19dd83a
Compare
Ldoppea
reviewed
Nov 10, 2023
| "androidBackgroundPermissionMessage": "Recording your movements requires to ≪ {backgroundPermissionOptionLabel} ≫" | ||
| "androidBackgroundPermissionMessage": "Recording your movements requires to ≪ {backgroundPermissionOptionLabel} ≫", | ||
| "androidNotificationTitle": "Location service on", | ||
| "androidNotificationDescription": "Your journey will be recorded into your Cozy" |
There was a problem hiding this comment.
No ES version?
Also this mention "Cozy", so I suppose we should get an alternative text in extra-language files
zatteo
force-pushed
the
feat/improve-translations-geolocation
branch
from
19dd83a to
23405d8
Compare
Ldoppea
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.