feat(client-core): Use throwContinueWait parameter in cubeSql method#10461
feat(client-core): Use throwContinueWait parameter in cubeSql method#10461MazterQyou wants to merge 1 commit intomasterfrom
throwContinueWait parameter in cubeSql method#10461Conversation
Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10461 +/- ##
===========================================
- Coverage 78.51% 57.65% -20.87%
===========================================
Files 472 222 -250
Lines 92294 17397 -74897
Branches 3563 3563
===========================================
- Hits 72469 10030 -62439
+ Misses 19287 6829 -12458
Partials 538 538
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| signal: options?.signal, | ||
| fetchTimeout: options?.timeout, | ||
| baseRequestId: options?.baseRequestId, | ||
| throwContinueWait: true, |
There was a problem hiding this comment.
Like this, it's a breaking change, right? I believe we've agreed to let users configure this parameter by passing an explicit option, and then we'll make it true by default on the API side in the next minor. So, I believe we need to take throwContinueWait from options here—and in the React client library as well.
There was a problem hiding this comment.
It's not a breaking change since this is a parameter passed by the client and client is designed to handle continue wait as it does with load (the same method is used behind the scenes).
| } | ||
|
|
||
| if (body.error === 'Continue wait') { | ||
| if (body.error?.includes('Continue wait')) { |
There was a problem hiding this comment.
Let's not do that, because potential it can be a part of error message that are not continue wait.
There was a problem hiding this comment.
The reason for this change is that we throw this Continue wait from backend-native as CubeError::internal which leads to the error having extra prefixes like External error:. I'm open to suggestions fixing the prefixes here but backend-native itself uses the same .contains method for testing continue wait so I felt like this brings them in line.
Check List
Description of Changes Made
This PR updates
cubeSqlmethod incubejs-client-coreto make use of the newthrowContinueWaitparameter.