Skip to content

feat(client-core): Use throwContinueWait parameter in cubeSql method #10461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MazterQyou wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

feat(client-core): Use throwContinueWait parameter in cubeSql method #10461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/cubejs-client-core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ class CubeApi {
body.error = text;
}

if (body.error === 'Continue wait') {
if (body.error?.includes('Continue wait')) {
Copy link
Member

@ovr ovr Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not do that, because potential it can be a part of error message that are not continue wait.

Copy link
Member Author

@MazterQyou MazterQyou Mar 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this change is that we throw this Continue wait from backend-native as CubeError::internal which leads to the error having extra prefixes like External error:. I'm open to suggestions fixing the prefixes here but backend-native itself uses the same .contains method for testing continue wait so I felt like this brings them in line.

await checkMutex();
if (options?.progressCallback) {
options.progressCallback(new ProgressResult(body as ProgressResponse));
Expand Down Expand Up @@ -742,6 +742,7 @@ class CubeApi {
signal: options?.signal,
fetchTimeout: options?.timeout,
baseRequestId: options?.baseRequestId,
throwContinueWait: true,
Copy link
Member

@igorlukanin igorlukanin Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this, it's a breaking change, right? I believe we've agreed to let users configure this parameter by passing an explicit option, and then we'll make it true by default on the API side in the next minor. So, I believe we need to take throwContinueWait from options here—and in the React client library as well.

Copy link
Member Author

@MazterQyou MazterQyou Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a breaking change since this is a parameter passed by the client and client is designed to handle continue wait as it does with load (the same method is used behind the scenes).

};

if (options?.cache) {
Expand Down
Loading