[c]: use GNUInstallDirs to help determine installation paths #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this handles cases where libraries should be installed in e.g. `/usr/lib64` rather than `/usr/lib`. https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this handles cases where libraries or
.cmakefiles should be installed in e.g./usr/lib64rather than/usr/lib.https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html
The C++ library already does this:
gherkin/cpp/CMakeLists.txt
Line 58 in d0d7a26
🤔 What's changed?
Use the
GNUInstallDirsCMake module to help determine installation paths for C libraries, headers, and configs.⚡️ What's your motivation?
Without this, on OS’s and architectures that use “multilib” directory layouts (e.g. Fedora on
x86_64), the libraries and configs would be installed system-wide under/usr/libwhen they should be in/usr/lib64. UsingGNUInstallDirsfixes that in the general case.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.