feat: keep filters in url #1615
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DanielSchiavini
commented
Nov 6, 2025
DanielSchiavini
commented
- move the filters from local storage to url
- test the new behavior
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xAlunara
previously approved these changes
Nov 7, 2025
Collaborator
0xAlunara
left a comment
0xAlunara
left a comment
There was a problem hiding this comment.
If you select any filter and then click "Reset filters" the URL doesn't remove the query like expected, but it becomes ?deprecatedMessage=no&tvl=10000~
Filters getting pretty complex 🧐
Collaborator
Author
imo it should be simpler now, cause we don't need migration logic, we don't need to filter the default filters etc
yeah this is a bug! Reset should just always make it |
DanielSchiavini
commented
Nov 10, 2025
|
|
||
| const { Spacing } = SizesAndSpaces | ||
|
|
||
| export const UserPositionFilterChips = ({ |
Collaborator
Author
There was a problem hiding this comment.
I inlined this component, it was just adding complexity since it's so simple. In the end, only filterProps were used btw
8 tasks
DanielSchiavini
requested review from
0xAlunara,
0xPearce,
0xtutti and
OnlyJousting
0xAlunara
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.