fix: can't enter input in search wallet when connecting to walletconnect #1624
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xAlunara
requested review from
0xPearce,
0xtutti,
DanielSchiavini and
OnlyJousting
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xAlunara
changed the title
0xtutti
approved these changes
Nov 8, 2025
DanielSchiavini
approved these changes
Nov 10, 2025
| The most reliable fix is to skip rendering this modal while WalletConnect | ||
| is connecting, rather than patching the tabIndex via a flaky JavaScript hack. | ||
| */ | ||
| ...(isConnectingType === 'walletConnect' && { display: 'none' }), |
Collaborator
There was a problem hiding this comment.
The magic string isn't ideal
Collaborator
Author
There was a problem hiding this comment.
It's not a magic string, it's the built in string type literal from wagmi! 😔
Collaborator
There was a problem hiding this comment.
That's why enums are better 🤓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the modal from rendering while connecting with WalletConnect to allow input in the "Search wallet" field. This change addresses a tabIndex issue caused by the MUI Dialog component. There's a big comment block explaining why I've decided to fix the issue this way.