Skip to content

fix: can't enter input in search wallet when connecting to walletconnect #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
+23 −1
Merged

fix: can't enter input in search wallet when connecting to walletconnect #1624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion packages/curve-ui-kit/src/features/connect-wallet/ui/WagmiConnectModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,29 @@ export const WagmiConnectModal = () => {
}))

return (
<ModalDialog open={showModal} onClose={closeModal} title={t`Connect Wallet`} titleAction={<WalletIcon />} compact>
<ModalDialog
open={showModal}
onClose={closeModal}
title={t`Connect Wallet`}
titleAction={<WalletIcon />}
compact
sx={{
/*
When connecting with WalletConnect, we hide this dialog because the MUI Dialog
component adds a tabIndex of -1 to its container. This prevents text input in
the "Search wallet" field of the WC modal — it's not a z-index issue, but
caused by the tabIndex itself.

Although MUI provides a slotProp for the container, the tabIndex is still set
to -1 internally, regardless of what you specify. Other slotProps work fine,
so this behavior seems hardcoded in MUI.

The most reliable fix is to skip rendering this modal while WalletConnect
is connecting, rather than patching the tabIndex via a flaky JavaScript hack.
*/
...(isConnectingType === 'walletConnect' && { display: 'none' }),
Copy link
Collaborator

@DanielSchiavini DanielSchiavini Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The magic string isn't ideal

Copy link
Collaborator Author

@0xAlunara 0xAlunara Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a magic string, it's the built in string type literal from wagmi! 😔

Copy link
Collaborator

@DanielSchiavini DanielSchiavini Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why enums are better 🤓

}}
>
{error ? (
<Alert variant="filled" severity="error">
<AlertTitle>{t`Error connecting wallet`}</AlertTitle>
Expand Down
Loading