Use controller-runtime's logging library #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoru-takeuchi
requested changes
Oct 10, 2024
| if err != nil { | ||
| return ctrl.Result{}, fmt.Errorf("failed to get Ceph cluster ID: %s: %s: %w", mbc.Namespace, mbc.Spec.PVC, err) | ||
| } | ||
| if clusterID != r.managedCephClusterID { | ||
| logger.Info("the target pvc is not managed by this controller", "name", req.Name, "namespace", req.Namespace, "error", err) | ||
| logger.Info("the target pvc is not managed by this controller", "error", err) |
There was a problem hiding this comment.
Suggested change
| logger.Info("the target pvc is not managed by this controller", "error", err) | |
| logger.Info("the target pvc is not managed by this controller") |
err is always nil since error check was done in L113.
| return ctrl.Result{}, err | ||
| } | ||
| restore.Status.Pool = pv.Spec.CSI.VolumeAttributes["pool"] | ||
| if restore.Status.Pool == "" { | ||
| logger.Error("pool not found in PV manifest", "backup", backup.Name, "namespace", backup.Namespace) | ||
| logger.Error(err, "pool not found in PV manifest", "backup", backup.Name, "namespace", backup.Namespace) |
There was a problem hiding this comment.
err is nil since error check was done in L146. Please create a new error.
We used slog for logging in our codes, but controller-runtime uses its own log system. Therefore, Mantle output logs with two different formats. To avoid this, use the controller-runtime's library everywhere. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
controller-runtime sets a target object name into logger in default, it is unenecessary. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
The error is determined as a nil, it is unnecessary to log it. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
satoru-takeuchi
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to use the controller-runtime's logging library rather than slog everywhere.