Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use controller-runtime's logging library #50

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Use controller-runtime's logging library #50

merged 3 commits into from
Oct 10, 2024

Commits on Oct 10, 2024

  1. Use the controller-runtime's log library 

    We used slog for logging in our codes, but controller-runtime uses its
own log system. Therefore, Mantle output logs with two different
formats. To avoid this, use the controller-runtime's library everywhere.

Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
    @toshipp
    toshipp committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    620b9b8 View commit details
    Browse the repository at this point in the history

  2. Don't log unnecessary object names 

    controller-runtime sets a target object name into logger in default, it
is unenecessary.

Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
    @toshipp
    toshipp committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    76ba8e9 View commit details
    Browse the repository at this point in the history

  3. Don't log a nil error 

    The error is determined as a nil, it is unnecessary to log it.

Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
    @toshipp
    toshipp committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    51f9a1f View commit details
    Browse the repository at this point in the history