This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
feat: add CAPX API #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
force-pushed
the
dkoshkin/feat-add-capx-api
branch
2 times, most recently
from
1bc4015 to
1970b45
Compare
faiq
reviewed
Mar 29, 2024
dkoshkin
force-pushed
the
dkoshkin/feat-add-capx-api
branch
from
1970b45 to
d53ee24
Compare
|
@deepakm-ntnx I also set required fields for the nodes based on the type, PTAL d53ee24 |
dkoshkin
force-pushed
the
dkoshkin/feat-add-capx-api
branch
from
b45d67f to
06c094f
Compare
Copied this from an existing PR.
supershal
reviewed
Apr 1, 2024
dkoshkin
force-pushed
the
dkoshkin/feat-add-capx-api
branch
from
06c094f to
46f7893
Compare
dkoshkin
force-pushed
the
dkoshkin/feat-add-capx-api
branch
from
8380c67 to
870884b
Compare
faiq
reviewed
Apr 2, 2024
| @@ -94,6 +94,7 @@ require ( | |||
| github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | |||
| github.com/modern-go/reflect2 v1.0.2 // indirect | |||
| github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect | |||
| github.com/nutanix-cloud-native/prism-go-client v0.3.4 // indirect | |||
|
Closing in-favor of #6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to propose this while we working on #6
This PR adds the minimum API that is needed to create a CAPX cluster, making it easier to review just this part and would unblock the CCM work I'm working on.
clusterv1.APIEndpointandcorev1.LocalObjectReferenceI've verified I didn't break the existing PR by making the required changes in 3360d27 and running the unit tests.