This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
feat: Add support for CAPX #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faiq
reviewed
Mar 21, 2024
charts/cluster-api-runtime-extensions-nutanix/defaultclusterclasses/nutanix-cluster-class.yaml
Outdated
Show resolved
Hide resolved
faiq
reviewed
Mar 21, 2024
charts/cluster-api-runtime-extensions-nutanix/defaultclusterclasses/nutanix-cluster-class.yaml
Outdated
Show resolved
Hide resolved
faiq
reviewed
Mar 21, 2024
charts/cluster-api-runtime-extensions-nutanix/defaultclusterclasses/nutanix-cluster-class.yaml
Outdated
Show resolved
Hide resolved
faiq
reviewed
Mar 27, 2024
This was referenced Mar 27, 2024
Closed
deepakm-ntnx
commented
Mar 29, 2024
|
@deepakm-ntnx the commits need to have the conventional commits format Can you please squash the commits here that make sense to be together, I think that will also make it simpler to review. |
dkoshkin
reviewed
Apr 1, 2024
hack/examples/bases/nutanix/clusterclass/kustomization.yaml.tmpl
Outdated
Show resolved
Hide resolved
pkg/handlers/nutanix/mutation/controlplaneendpoint/variables_test.go
Outdated
Show resolved
Hide resolved
pkg/handlers/nutanix/mutation/machinedetails/inject_control_plane.go
Outdated
Show resolved
Hide resolved
pkg/handlers/nutanix/mutation/machinedetails/inject_control_plane.go
Outdated
Show resolved
Hide resolved
dkoshkin
reviewed
Apr 1, 2024
deepakm-ntnx
force-pushed
the
KRBN-8015
branch
2 times, most recently
from
c00bb82
to
53a057f
Compare
dkoshkin
reviewed
Apr 1, 2024
The patch failed with the following error: got failure response with message failed to apply JSON patches to input: replace operation does not apply: doc is missing key: /spec/template/spec/prismCentral/credentialRef/namespace: missing value.
dkoshkin
previously approved these changes
Apr 2, 2024
There was a problem hiding this comment.
I'm happy with this, thanks @deepakm-ntnx!
Tested locally with both Calico and Cilium, everything looks great.
CONTROL_PLANE_ENDPOINT_IP=<>
CONTROL_PLANE_ENDPOINT_PORT=6443
NUTANIX_ENDPOINT=<>
NUTANIX_USER=<>
NUTANIX_PASSWORD=<>
NUTANIX_PRISM_ELEMENT_CLUSTER_NAME=<>
NUTANIX_INSECURE=false
NUTANIX_SUBNET_NAME=<>
NUTANIX_MACHINE_TEMPLATE_IMAGE_NAME=ubuntu-2204-kube-v1.28.7.qcow2
CLUSTER_NAME=dkoshkin-nutanix-caren-1
CLUSTER_FILE=examples/capi-quick-start/nutanix-cluster-calico-crs.yaml
KUBERNETES_VERSION=v1.28.7
clusterctl generate cluster ${CLUSTER_NAME} \
--from ${CLUSTER_FILE} \
--kubernetes-version ${KUBERNETES_VERSION} \
--worker-machine-count 1 | \
kubectl apply --server-side -f -
Nodes came up:
$ kubectl get nodes
NAME STATUS ROLES AGE VERSION
dkoshkin-nutanix-caren-1-drvx2-tk7c5 Ready control-plane 3m13s v1.28.7
dkoshkin-nutanix-caren-1-md-0-9pmr9-bj6rx-gx982 Ready <none> 2m15s v1.28.7
dkoshkin
approved these changes
Apr 3, 2024
thunderboltsid
approved these changes
Apr 3, 2024
jimmidyson
pushed a commit
that referenced
this pull request
Apr 11, 2024
* fix: added support for capx * refactor: reuse existing CAPX types * fix: set allowed enums for Nutanix resource types * fix: set required for Nutanix node type * fix: reuse resource.Quantity types * fix: set defaults and validation * fix: rename field to subnets * refactor: fix handlers after API changes * test: add new unit tests * refactor: bring back host instead of address * fix: examples with updated APIs * fix: using latest capx private brach to test kube-vip fix * fix: set namespace for credentialRef The patch failed with the following error: got failure response with message failed to apply JSON patches to input: replace operation does not apply: doc is missing key: /spec/template/spec/prismCentral/credentialRef/namespace: missing value. * docs: fix users example * docs: deploying Calico for Nutanix * fix: added basic docs for nutanix mutations * fix: lint related fixes * docs: minor changes --------- Co-authored-by: Dimitri Koshkin <dimitri.koshkin@nutanix.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pushed from nutanix-cloud-native#384 to this repo
Also patches from #5 are required
to get latest nutanix apis from capx repo
to regenerate example Cluster with topology yamls
To run unit tests
To deploy cre controller as well as nutanix provider and cluster class of nutanix
To deploy nutanix cluster with topology with cre annotations