Conversation
The battery sensor was hardcoded to the default DPS code (104) which doesn't work for models using non-default codes. For example, the T2267 (Eufy L60 SES) uses code 163, causing battery to always show as unavailable. - Query getDpsCodes() to get the correct DPS code per model - Add null checks to handle startup before connection established - Improve debug logging to show which codes are being used - Start sensor unavailable until data arrives from vacuum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The battery sensor was hardcoded to the default DPS code (104) which doesn't work for models using non-default codes. For example, the T2267 (Eufy L60 SES) uses code 163, causing battery to always show as unavailable.
This fixes #347
Disclaimer: vibe coded with Claude Haiku 4.5 - including this description. Tested with my own Eufy L60 SES. No clue if this PR makes any sense for you but it works for me.