Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDFHER-76 - Add missing form elements and styling to AdvancedSearch #735

Conversation

kasperbirch1
Copy link
Contributor

@kasperbirch1 kasperbirch1 commented Sep 30, 2024

Link to issue

https://reload.atlassian.net/browse/DDFHER-76

Depend on

danskernesdigitalebibliotek/dpl-react#1440
danskernesdigitalebibliotek/dpl-cms#1585

Description

Added form elements that were previously implemented in dpl-react. Introduced a form wrapper to ensure appropriate spacing between elements and used the Textarea component for a consistent form style.

Added form elements that were previously implemented in `dpl-react`. Introduced a form wrapper to ensure appropriate spacing between elements and used the `Textarea` component for a consistent form style.
@kasperbirch1 kasperbirch1 changed the title Add missing form elements and styling to AdvancedSearch DDFHER-76 - Add missing form elements and styling to AdvancedSearch Sep 30, 2024
Copy link
Contributor

@Dresse Dresse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kasperbirch1 kasperbirch1 merged commit 93d5c0b into develop Oct 1, 2024
8 checks passed
@kasperbirch1 kasperbirch1 deleted the DDFHER-76-filtering-on-onshelf-location-and-sublocation-should-be-reflected-in-links branch October 1, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants