DDFHER-76 - Add "location" and "sublocation" URL parameters in advanced search (CQL) #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperbirch1
changed the title
kasperbirch1
force-pushed
the
DDFHER-76-filtering-on-onshelf-location-and-sublocation-should-be-reflected-in-links
branch
from
53f4fb7
to
7173d08
Compare
kasperbirch1
commented
Sep 30, 2024
kasperbirch1
commented
Sep 30, 2024
Implements URL parameters for `location` and `sublocation`. Additionally, the parameters from the URL are processed in `useEffectOnce`, ensuring they are included on the first load. The `removeQueryParametersFromUrl` function is used to remove the parameters if their strings are empty. Currently, the code does not handle multiple "locations" or "sublocations." It is unclear whether this is necessary, and I am awaiting a response from DDF regarding this.
…es in advanced search (CQL) This allow users to search across several locations or sublocations by using a comma-separated string in the input fields.
- Location - Sublocation
kasperbirch1
force-pushed
the
DDFHER-76-filtering-on-onshelf-location-and-sublocation-should-be-reflected-in-links
branch
from
7173d08
to
230ca57
Compare
…` + Add form wrapper The `Textarea` is added to keep the structure consistent, and the class `advanced-search-cql-form` is used to maintain spacing between elements.
kasperbirch1
force-pushed
the
DDFHER-76-filtering-on-onshelf-location-and-sublocation-should-be-reflected-in-links
branch
from
230ca57
to
a721f13
Compare
kasperg
requested changes
Oct 1, 2024
There was a problem hiding this comment.
👍 This seems to work well.
I am not totally satisfied about the code structure in advanced search in the way we handle url parameters etc. but that is none of your fault. The implementation follows what is.
I have a few comments regarding the code structure of the next form components.
I appreciate the updated design for the form elements. I think the form looks better.
Consider if they take up too much vertical space between the title and the form.
As I see it some of the issue is caused by different approaches in the "normal" form and in the CQL form. One uses margins. The other grip/gap.
To keep all form elements in the same place, as we do in the design system.
Also update `Label` to add "*" after label name for `required` fields
The 'name' attribute was removed from the <textarea> because its data does not need to be sent to the server during form submission.
…der` This adjusts the spacing between the title and the form, reflecting the markup in the DPL design system.
This was a leftover from when I moved `TextInput` to the `forms` folder. However, upon review, I noticed that this issue occurred in many places.
kasperbirch1
commented
Oct 1, 2024
| @@ -51,7 +45,11 @@ const App = ({ story }) => <Store>{WrappedStory(story)}</Store>; | |||
| // Consideration for the future - using addon-redux could bring value. | |||
| // It wasn't implemented to begin with because it wasn't compatible with Storybook 6. | |||
| export const decorators = [ | |||
| Story => <><App story={Story} /></> | |||
| (Story) => ( | |||
There was a problem hiding this comment.
This was a Prettier (format on save) change. However, it should be the same result.
kasperg
approved these changes
Oct 1, 2024
kasperbirch1
deleted the
DDFHER-76-filtering-on-onshelf-location-and-sublocation-should-be-reflected-in-links
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFHER-76
Depend on
danskernesdigitalebibliotek/dpl-design-system#735
danskernesdigitalebibliotek/dpl-cms#1585
Description
This pull request implements URL parameters for
locationandsublocation. Additionally, the parameters from the URL are processed inuseEffectOnce, ensuring they are included on the first load. TheremoveQueryParametersFromUrlfunction is used to remove the parameters if their strings are empty.It also refactors the logic to allow users to search across multiple locations or sublocations by using a comma-separated string in the input fields.
Test
http://varnish.pr-1585.dpl-cms.dplplat01.dpl.reload.dk/advanced-search
Skaermoptagelse.2024-09-18.kl.15.49.16.mov