Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IAC assets to recreate static web apps for Docs and Blogs site #4166

Merged
merged 7 commits into from
May 31, 2024

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented May 30, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Adding /iac folder with bicep templates/scripts needed to recreate and configure a static web app suitable for hosting a docs site or blog site. Any sensitive or unique variables should be set as environment variables using the Readme and /iac/swa/infra/main.parameters.bicep as a reference.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk paulyuk requested review from a team as code owners May 30, 2024 03:31
@paulyuk paulyuk changed the base branch from v1.13 to v1.14 May 30, 2024 03:31
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
…leaving empty creates a default with a unique hash (but ugly for prod)

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk paulyuk self-assigned this May 30, 2024
@paulyuk
Copy link
Contributor Author

paulyuk commented May 30, 2024

As an end to end test I updated the publish token for the 1_7 version of the docset CI/CD to deploy to the new tenant (since it's low risk to anyone) and it's all working well from what I can see:

v1.7 docs on new dapr.io tenant:
https://kind-forest-0528f841e.5.azurestaticapps.net/

dapr blog on new dapr.io tenant:
https://delightful-pebble-097ed421e.5.azurestaticapps.net/

@hhunter-ms hhunter-ms merged commit 7e4996b into dapr:v1.14 May 31, 2024
6 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @paulyuk Enjoy your Dapr docs badge!

Copy link

holopin-bot bot commented Jun 17, 2024

Congratulations @paulyuk, you just earned a badge! Here it is: https://holopin.io/claim/clxj38a1x28650cl9gn0yq1pz

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants