Skip to content

Commit

Permalink
Bump the range to 20% (120).
Browse files Browse the repository at this point in the history
  • Loading branch information
darrenge committed Oct 15, 2024
1 parent 343e81b commit e69c9c0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-bdnbenchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
tool: 'benchmarkdotnet'
output-file-path: ./test/BDNPerfTests/BenchmarkDotNet.Artifacts/results/BDN.benchmark.${{ matrix.test }}-report-full-compressed.json
github-token: ${{ secrets.GITHUB_TOKEN }}
alert-threshold: '115%'
alert-threshold: '120%'
external-data-json-path: ./cache/benchmark-data.json
comment-on-alert: true
fail-on-alert: true
Expand Down
2 changes: 1 addition & 1 deletion test/BDNPerfTests/run_bdnperftest.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function AnalyzeResult {

# Check if the actual value is within the bounds
if ($dblfoundResultValue -ge $LowerBound -and $dblfoundResultValue -le $UpperBound) {
Write-Host "** ** PASS! ** Test Value result ($dblfoundResultValue) is in the acceptable range +/-$acceptablePercentRange% ($LowerBound -> $UpperBound) of expected value: $expectedResultValue "
Write-Host "** ** PASS! ** Test Value result ($dblfoundResultValue) is in the acceptable range +/-$acceptablePercentRange% ($LowerBound -> $UpperBound) of expected value: $expectedResultValue "
Write-Host "** "
return $true # the values are close enough
}
Expand Down

0 comments on commit e69c9c0

Please sign in to comment.