-
Notifications
You must be signed in to change notification settings - Fork 84
Add --test-type flag #2311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --test-type flag #2311
Conversation
Closes #2300 Some flags like disabling `TimerThrottlingForBackgroundTabs` cause warnings when launching chrome because it is not recommended for use during general browsing. Suppress these types of warnings with the `--test-type` flag which indicates to chrome that this is a dev focused workflow where such flags are expected.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the --test-type flag to Chrome launch arguments to suppress certain warnings, which is a useful improvement for development workflows. The associated CHANGELOG.md and pubspec.yaml files have been updated accordingly. My review includes a minor suggestion to improve a comment's readability and adherence to the project's style guide, specifically the Effective Dart guidelines.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
How about also adding: For developers, if Chrome is closed abruptly (without using the Quit/Close option in the Chrome UI), it shows the “session crashed” bubble on the next launch. Since every launch of a developer Chrome instance is independent of previous sessions, this flag prevents that unnecessary warning. |
#2311 (comment) For development focused browser launches it's typically not useful to get extra warnings that the previous session crashed. Add a flag to disable the startup bubble and treat separate launches as independent.
Seems like a good idea. Thanks. #2321 |
Closes #2300
Some flags like disabling
TimerThrottlingForBackgroundTabscausewarnings when launching chrome because it is not recommended for use
during general browsing. Suppress these types of warnings with the
--test-typeflag which indicates to chrome that this is a dev focusedworkflow where such flags are expected.