fix: correct misleading comment on executed_branch None case#92
Merged
drmingdrmer merged 1 commit intodatabendlabs:mainfrom Mar 6, 2026
Merged
fix: correct misleading comment on executed_branch None case#92drmingdrmer merged 1 commit intodatabendlabs:mainfrom
drmingdrmer merged 1 commit intodatabendlabs:mainfrom
Conversation
The None case can legitimately occur when the condition predicate evaluates to false and there is no else_then fallback branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR corrects an inaccurate comment in the KvTransactionReply -> TxnReply conversion logic to reflect that executed_branch = None is a valid outcome when no branch matches, preserving the legacy “else” mapping.
Changes:
- Update the comment for the
executed_branch: Nonematch arm to describe the legitimate “no match + no else_then fallback” scenario. - Clarify that the conversion maps this case to
execution_path="else"for backward compatibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xp-trumpet
approved these changes
Mar 6, 2026
Collaborator
xp-trumpet
left a comment
xp-trumpet
left a comment
There was a problem hiding this comment.
@xp-trumpet reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on drmingdrmer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
fix: correct misleading comment on executed_branch None case
The None case can legitimately occur when the condition predicate
evaluates to false and there is no else_then fallback branch.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com