Skip to content

fix: correct misleading comment on executed_branch None case #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drmingdrmer merged 1 commit into from
Mar 6, 2026
Merged

fix: correct misleading comment on executed_branch None case #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/common/types/src/kv_transaction/convert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,9 +359,9 @@ impl pb::KvTransactionReply {

let (success, execution_path) = match self.executed_branch {
None => {
// Should not happen: the condition/if_then branch is always
// present and Predicate::and([]) is vacuously true,
// so at least that branch always matches.
// No branch matched. This happens when the condition
// predicate evaluates to false and there is no else_then
// fallback. Map to "else" for backward compatibility.
(false, "else".to_string())
}
Some(i) => {
Expand Down