Change: rename AsyncOneshotSendExt to OneshotSender, remove TokioOneShotSender
#1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oOneShotSender` **Removal of `TokioOneShotSender`:** Previously, `TokioOneShotSender(tokio::sync::oneshot::Sender)` was used to implement `Debug` for a oneshot sender. Given that `Debug` implementation is not a mandatory requirement, `TokioOneShotSender` is no longer necessary and has been removed. **Rename `AsyncOneshotSendExt` to `OneshotSender`:** The renaming reflects a more streamlined and intuitive naming convention. Upgrade tip: - rename `AsyncOneshotSendExt` to `OneshotSender` --- - `AsyncOneshotSendExt` and `TokioOneShotSender` are introduced in databendlabs#1026
drmingdrmer
force-pushed
the
93-simplify-oneshot
branch
from
5570a3b
to
0ebecb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Change: rename
AsyncOneshotSendExttoOneshotSender, removeTokioOneShotSenderRemoval of
TokioOneShotSender: Previously,TokioOneShotSender(tokio::sync::oneshot::Sender)was used toimplement
Debugfor a oneshot sender. Given thatDebugimplementation is not a mandatory requirement,
TokioOneShotSenderisno longer necessary and has been removed.
Rename
AsyncOneshotSendExttoOneshotSender: The renamingreflects a more streamlined and intuitive naming convention.
Upgrade tip:
AsyncOneshotSendExttoOneshotSenderAsyncOneshotSendExtandTokioOneShotSenderare introduced in AsyncRuntime::oneshot #1026This change is