Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: rename AsyncOneshotSendExt to OneshotSender, remove TokioOneShotSender #1157

Merged
merged 1 commit into from
Jul 8, 2024

Commits on Jul 8, 2024

  1. Change: rename AsyncOneshotSendExt to OneshotSender, remove `Toki…

    …oOneShotSender`
    
    **Removal of `TokioOneShotSender`:** Previously,
    `TokioOneShotSender(tokio::sync::oneshot::Sender)` was used to
    implement `Debug` for a oneshot sender. Given that `Debug`
    implementation is not a mandatory requirement, `TokioOneShotSender` is
    no longer necessary and has been removed.
    
    **Rename `AsyncOneshotSendExt` to `OneshotSender`:** The renaming
    reflects a more streamlined and intuitive naming convention.
    
    Upgrade tip:
    
    - rename `AsyncOneshotSendExt` to `OneshotSender`
    
    ---
    
    - `AsyncOneshotSendExt` and `TokioOneShotSender` are introduced in databendlabs#1026
    drmingdrmer committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0ebecb7 View commit details
    Browse the repository at this point in the history