Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new 'AUTO' format to workspace CLI to allow importing extra files types #643

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

osuleiman
Copy link

@osuleiman osuleiman commented May 17, 2023

This is a minimalistic update to allow the new format 'AUTO' to be used which is available on the [REST API](https://learn.microsoft.com/en-us/azure/databricks/dev-tools/api/latest/workspace#notebookexportformat:~:text=Description-,AUTO,-(Public%20Preview) as part of the release of workspace files.

This update will allow the importing of all file formats and not only the initial list of files (SOURCE, HTML, JUPYTER, DBC).

Introduced the addition of the flag "are_workspace_files" or "wf" for import_dir command to help switch between current functionality, and the importing files within a directory using their original extension.

image

@gdaiha
Copy link

gdaiha commented May 22, 2023

Man, great PR!
This will help a lot users that wants to keep .py module files with their own extension.

@adminsoyhuce
Copy link

+1 This PR is needed !
Thanks :)

@MathisFasolo1
Copy link

Thanks !

@rboyes
Copy link

rboyes commented Jun 23, 2023

Yep I need this as well.

@wagnerbsouza
Copy link

This is really important.
Trying to move init-scripts files from DBFS to Workspace, but can't do it programmatically.
Have several scripts that are uploaded from an automated pipeline, which are now being uploaded manually.
Not optimal at all.

@adminsoyhuce
Copy link

hello @infarejf any chances to have this PR reviewed ? :)
Thanks

@osuleiman osuleiman requested a review from infarejf August 3, 2023 11:36
@infarejf
Copy link

infarejf commented Aug 7, 2023

hello @infarejf any chances to have this PR reviewed ? :) Thanks

Hi, I see that I approved the changes on July 6th, but that was not intentional and I was not aware of this. Can you please defer the review to someone else? Thanks. Br Jesper

@osuleiman
Copy link
Author

@pietern Would you be able to help with the reviewal of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants