Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the docker commands for compilation #106

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Clarify the docker commands for compilation #106

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4838840
Clarify the docker commands for compilation
luiscla27 Sep 1, 2024
bb0ec5e
Clarified how to run commands in docker
luiscla27 Sep 2, 2024
c512b83
Merge branch 'davidrmiller:main' into patch-2
luiscla27 Sep 13, 2024
de47a85
Added cmake installation
luiscla27 Sep 13, 2024
d7b2a7c
Update README.md
davidrmiller Oct 10, 2024
2a0db6f
Update README.md
davidrmiller Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@ RUN apt-get update && apt-get install -yqq \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

RUN apt-get update && apt install -yqq python3-igraph
RUN apt-get update && apt-get install -yqq python3-igraph

RUN apt-get update && apt-get install -yqq \
cimg-dev \
gnuplot \
libopencv-dev \
cmake \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't technically necessary before, but it seems like the option is here now so it can't hurt to include it.

&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

Expand Down
10 changes: 8 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ To build a Docker environment in which you can compile the program:
docker build -t biosim4 .
```

You can then compile the program with an ephemeral container:
You can then compile the program with an ephemeral container, remember that `pwd` stands for the fullpath of your `biosim4` project, something like `C:/full-path-in-windows/to-your/biosim4-folder/biosim4`:
davidrmiller marked this conversation as resolved.
Show resolved Hide resolved

```sh
docker run --rm -ti -v `pwd`:/app --name biosim biosim4 make
Expand All @@ -249,8 +249,14 @@ When you exit the container, the files compiled in your container files will per

A `CMakeList.txt` file is provided to allow development, build, test, installation and packaging with the CMake tool chain and all IDE's that support CMake.

To build with cmake you need to install cmake. Once installed use the procedure below:
To build with cmake you need to install cmake.

If you're using docker, `cmake` is already installed. So, you can directly open its terminal to use it:
davidrmiller marked this conversation as resolved.
Show resolved Hide resolved
```sh
docker run --rm -ti -v `pwd`:/app --name biosim biosim4 bash
```

Once cmake is installed use the procedure below:
```sh
mkdir build
cd build
Expand Down
Loading