-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration workflow update to support all-in-one adapter testing #1149
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
d9ca2b5
Create run-name
gshank be9ff67
Update integration.yml
gshank e3b033e
update update_dev_packages.sh
gshank 2cbbddd
Tweak run-name
gshank af6dbb3
Adjust run-name, add additional checkout option
gshank 9f33856
Revert "Adjust run-name, add additional checkout option"
gshank 5fdc704
Try another run-name
gshank 6912bb3
Try another run-name tweak
gshank 103e403
Add checking out adapter branch
gshank 6cf2424
actually add adapter_branch input
gshank 39f922b
Don't change adapter branch for now
gshank 60c5306
Try cat dev-requirements.txt
gshank 4d63b29
Fix update_dev_packages.sh
gshank ecd0ea6
Merge branch 'main' into integration_workflow_update
gshank e9e5673
Remove workflow_call
gshank f3781be
Remove update_dbt_core_branch.sh
gshank fea9256
Use adapter_branch
gshank fa42ff2
Rename update_dev_dependency_branches, add dbt-common
gshank 6500847
Fix script name
gshank b49d02b
Add quotes to default
gshank cb1e38c
Tweak if for repository checkout
gshank 4918412
Fix typo
gshank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
#!/bin/bash -e | ||
set -e | ||
|
||
|
||
dbt_adapters_branch=$1 | ||
dbt_core_branch=$2 | ||
dbt_common_branch=$3 | ||
target_req_file="dev-requirements.txt" | ||
core_req_sed_pattern="s|dbt-core.git.*#egg=dbt-core|dbt-core.git@${dbt_core_branch}#egg=dbt-core|g" | ||
adapters_req_sed_pattern="s|dbt-adapters.git|dbt-adapters.git@${dbt_adapters_branch}|g" | ||
common_req_sed_pattern="s|dbt-common.git|dbt-common.git@${dbt_common_branch}|g" | ||
if [[ "$OSTYPE" == darwin* ]]; then | ||
# mac ships with a different version of sed that requires a delimiter arg | ||
sed -i "" "$adapters_req_sed_pattern" $target_req_file | ||
sed -i "" "$core_req_sed_pattern" $target_req_file | ||
sed -i "" "$common_req_sed_pattern" $target_req_file | ||
else | ||
sed -i "$adapters_req_sed_pattern" $target_req_file | ||
sed -i "$core_req_sed_pattern" $target_req_file | ||
sed -i "$common_req_sed_pattern" $target_req_file | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we anticipate other workflows (i.e. in dbt-core) wanting to run this workflow? Should we also add
workflow_call
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workflow_call just calls the action code, without actually executing in this repository. We might want to standardize on an action in a central repository, but I'm guessing it wouldn't be in dbt-snowflake. Workflow_dispatch works for cross-repo calls. I'm running these now with a script, but once the individual repository changes are in place I'm going to try to set up an action in dbt-adapters to call all of the individual adapter integration tests and see how that goes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed w/ @gshank,
workflow_dispatch
is effectivelyworkflow_call
+ the workflow repo's code in this scenario, which is what we want.