Integration workflow update to support all-in-one adapter testing #1149
Conversation
This reverts commit af6dbb3.
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
| @@ -34,10 +36,26 @@ on: | |||
| # manual trigger | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
Do we anticipate other workflows (i.e. in dbt-core) wanting to run this workflow? Should we also add workflow_call?
There was a problem hiding this comment.
Workflow_call just calls the action code, without actually executing in this repository. We might want to standardize on an action in a central repository, but I'm guessing it wouldn't be in dbt-snowflake. Workflow_dispatch works for cross-repo calls. I'm running these now with a script, but once the individual repository changes are in place I'm going to try to set up an action in dbt-adapters to call all of the individual adapter integration tests and see how that goes.
There was a problem hiding this comment.
Agreed w/ @gshank, workflow_dispatch is effectively workflow_call + the workflow repo's code in this scenario, which is what we want.
|
Pull requests in other repos: |
resolves #
Problem
When testing changes to adapters, particularly dbt-adapters changes but also some core changes, we need to execute integration tests on all of the adapters, with the ability to specify dbt-adapters branch, dbt-core branch, and sometimes the local adapter branch.
Solution
Add additional input fields for the "workflow_dispatch" event: "dbt_adapter_branch", and "name". The name helps to identify individual runs in the lists of workflow runs, which can get lost. Also there's no good way to connect up a rest api workflow run or a gh cli workflow run with the matching run result, so adding a distinctive name assists in finding the correct results.
Checklist