Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration workflow update to support all-in-one adapter testing #1149
Integration workflow update to support all-in-one adapter testing #1149
Changes from 17 commits
d9ca2b5
be9ff67
e3b033e
2cbbddd
af6dbb3
9f33856
5fdc704
6912bb3
103e403
6cf2424
39f922b
60c5306
4d63b29
ecd0ea6
e9e5673
f3781be
fea9256
fa42ff2
6500847
b49d02b
cb1e38c
4918412
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we anticipate other workflows (i.e. in dbt-core) wanting to run this workflow? Should we also add
workflow_call
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workflow_call just calls the action code, without actually executing in this repository. We might want to standardize on an action in a central repository, but I'm guessing it wouldn't be in dbt-snowflake. Workflow_dispatch works for cross-repo calls. I'm running these now with a script, but once the individual repository changes are in place I'm going to try to set up an action in dbt-adapters to call all of the individual adapter integration tests and see how that goes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed w/ @gshank,
workflow_dispatch
is effectivelyworkflow_call
+ the workflow repo's code in this scenario, which is what we want.