Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination for registry.access.redhat.com #92

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

NautiluX
Copy link
Contributor

registry.access.redhat.com behaves the same way as quay.io.
Need this fix for Dependabot to be able to page through responses of repositories on registry.access.redhat.com.

See dependabot/dependabot-core#7562

@deitch
Copy link
Owner

deitch commented Jul 17, 2023

Thanks for catching this, @NautiluX . Waiting for CI clean and then will merge in.

@deitch deitch merged commit ccf0f7c into deitch:master Jul 17, 2023
@NautiluX
Copy link
Contributor Author

NautiluX commented Jul 17, 2023

Thanks @deitch! Do you have plans as to when this will be included in a new release/tag so I can propose an upgrade of the dependency in Dependabot?

@NautiluX NautiluX mentioned this pull request Jul 18, 2023
deitch pushed a commit that referenced this pull request Aug 1, 2024
….redhat.com registries (#107)

Remove special cases for quay.io & registry.access.redhat.com:
they were added by #63 and #92, but don't seem necessary anymore:

```
$ curl -Is https://quay.io/v2/keycloak/keycloak/tags/list | grep -i link
link: </v2/keycloak/keycloak/tags/list?n=100&last=23.0.4-0>; rel="next"
```

```
$ curl -Is https://registry.access.redhat.com:443/v2/ubi8/ubi-minimal/tags/list | grep -i link
Link: </v2/ubi8/ubi-minimal/tags/list?n=100&last=8.7-1031-source>; rel="next"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants