check spinner bounds #3412
Merged
check spinner bounds #3412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test the changes in this pull request, install this apk: |
Hocuri
approved these changes
Nov 5, 2024
Spinner is very picky about bad selections, this is an accident waiting to happen - eg. if new values are introduces or someone thinks, the "deprecated" case can be removed. better do not trust incoming data.
r10s
force-pushed
the
r10s/check-spinner-bounds
branch
from
169f0b4
to
ce42661
Compare
r10s
force-pushed
the
r10s/check-spinner-bounds
branch
from
ce42661
to
af87948
Compare
|
To test the changes in this pull request, install this apk: |
adbenitez
approved these changes
Nov 5, 2024
|
should we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can be merged to #3410 or later to main
Spinner is very picky about bad selections,
this is an accident waiting to happen -
eg. if new values are introduced
or someone thinks, the "deprecated" case can be removed.
better do not trust incoming data.
nb: first i did a "clip to bounds", so that larger values get the "maximum", however, although anything is better than always crashing, i think it is better to for for "default" in this case. however, this requires the "deprecated" check introduced by #3410 for the next time at least (iOS and desktop always write a
3, probably also DeltaTouch)