fix: Accept the deprecated 3 as an alias for 2 #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hocuri
commented
Nov 4, 2024
| @@ -384,7 +384,6 @@ | |||
| android:layout_width="0dp" | |||
| android:layout_height="48dp" | |||
| android:entries="@array/pref_dc_certck_entries" | |||
| android:entryValues="@array/pref_dc_certck_values" | |||
There was a problem hiding this comment.
This was supposed to map "Accept invalid certificates" to 3. This didn't actually work, though, so the behavior doesn't actually change here.
adbenitez
approved these changes
Nov 4, 2024
|
did a PR fixing the documentation for the CFFI as well, deltachat/deltachat-core-rust#6176 |
r10s
approved these changes
Nov 4, 2024
|
To test the changes in this pull request, install this apk: |
Merged
|
so that we can sleep better, i created #3412 :) |
i agree, lesson learned. we should try harder to keep things stable for UI. we had a similar hickup with DC_QR_BACKUP2 recently. |
|
Merging since it fixes a crash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3408 by automatically changing a 3 to 2.
3 is a deprecated alias for 2, so all UIs now need to handle both values. I think it wasn't a good idea to deprecate 3 in the first place, but it's not worth it going back now.
I tested this PR like this:
imap_certificate_checksis 2imap_certificate_checksis 3imap_certificate_checksis 2