more naming tweaks

department-of-veterans-affairs · Sep 19, 2024 · 9414254 · 9414254
1 parent 0fb4fee
commit 9414254
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/modules/simple_forms_api/app/services/simple_forms_api/s3/submission_archive_builder.rb b/modules/simple_forms_api/app/services/simple_forms_api/s3/submission_archive_builder.rb
@@ -118,9 +118,10 @@ def form_data_hash
 
       # Name the form PDFs and/or individual submission folders
       # uniquely, using a field that also appears in the manifest.
-      # The recommended format is Formnumber-vagov-submission ID
+      # The recommended format is Form-number-vagov-submission ID
       def submission_pdf_filename
-        @submission_pdf_filename ||= "#{form_data_hash['form_number']}-vagov-#{benefits_intake_uuid}.pdf"
+        form_number = form_data_hash['form_number']
+        @submission_pdf_filename ||= "form_#{form_number}_vagov_#{benefits_intake_uuid}.pdf"
       end
     end
   end

diff --git a/modules/simple_forms_api/app/services/simple_forms_api/s3/submission_archiver.rb b/modules/simple_forms_api/app/services/simple_forms_api/s3/submission_archiver.rb
@@ -117,8 +117,8 @@ def s3_submission_file_path
       end
 
       def unique_file_name
-        form_number = @JSON.parse(submission.form_data)['form_number']
-        @unique_file_name ||= "form_#{form_number}_#{benefits_intake_uuid}"
+        form_number = JSON.parse(submission.form_data)['form_number']
+        @unique_file_name ||= "form_#{form_number}_vagov_#{benefits_intake_uuid}"
       end
 
       def submission_pdf_filename