[SIMPLE_FORMS] feat: updates to submission builder in accordance with new direction #18517
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
require-backend-approval
test-passing
ready-for-backend-review
and removed
require-backend-approval
labels
va-vfs-bot
temporarily deployed
to
jap/simple-forms/1633-submission-archive-tweaks/main/main
github-actions
bot
added
require-backend-approval
ready-for-backend-review
and removed
ready-for-backend-review
require-backend-approval
test-passing
labels
pennja
commented
Sep 19, 2024
| def submission_pdf_filename | ||
| @submission_pdf_filename ||= "form_#{form_data_hash['form_number']}.pdf" | ||
| form_number = form_data_hash['form_number'] | ||
| @submission_pdf_filename ||= "form_#{form_number}_vagov_#{benefits_intake_uuid}.pdf" |
There was a problem hiding this comment.
I'm using underscores here given that both the form_number and benefits_intake_uuid will contain dashes.
pennja
commented
Sep 19, 2024
| @@ -29,7 +29,7 @@ def handle_error(message, error, **) | |||
| end | |||
|
|
|||
| def temp_directory_path | |||
| @temp_directory_path ||= Rails.root.join("tmp/#{benefits_intake_uuid}-#{SecureRandom.hex}/").to_s | |||
| @temp_directory_path ||= Rails.root.join("tmp/#{benefits_intake_uuid}-#{SecureRandom.hex}-archive/").to_s | |||
There was a problem hiding this comment.
Ensuring there are no collisions with similar temp folder/file logic elsewhere.
github-actions
bot
added
test-passing
ready-for-backend-review
require-backend-approval
and removed
ready-for-backend-review
require-backend-approval
labels
Thrillberg
previously approved these changes
Sep 19, 2024
pennja
force-pushed
the
jap/simple-forms/1633-submission-archive-tweaks
branch
from
067adab
to
c2bff7f
Compare
github-actions
bot
added
require-backend-approval
test-passing
ready-for-backend-review
test-failure
and removed
require-backend-approval
labels
va-vfs-bot
temporarily deployed
to
jap/simple-forms/1633-submission-archive-tweaks/main/main
|
@pennja it's probably worth merging master after the changes we made |
pennja
force-pushed
the
jap/simple-forms/1633-submission-archive-tweaks
branch
from
c2bff7f
to
9005220
Compare
github-actions
bot
added
require-backend-approval
and removed
ready-for-backend-review
require-backend-approval
test-passing
labels
ryan-mcneil
approved these changes
Sep 24, 2024
|
Backend-review-group approval confirmed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done
Requested Feedback
Any