Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIMPLE_FORMS] feat: updates to submission builder in accordance with new direction #18517

Merged
merged 1 commit into from
Sep 24, 2024
+2 −4
Merged

[SIMPLE_FORMS] feat: updates to submission builder in accordance with new direction #18517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/simple_forms_api/app/services/simple_forms_api/s3/utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def handle_error(message, error, **)
end

def temp_directory_path
@temp_directory_path ||= Rails.root.join("tmp/#{benefits_intake_uuid}-#{SecureRandom.hex}/").to_s
@temp_directory_path ||= Rails.root.join("tmp/#{benefits_intake_uuid}-#{SecureRandom.hex}-archive/").to_s
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensuring there are no collisions with similar temp folder/file logic elsewhere.

end

def s3_resource
Expand Down
4 changes: 1 addition & 3 deletions modules/simple_forms_api/spec/services/s3/submission_archive_builder_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@
attachments: nil,
benefits_intake_uuid:,
file_path: nil,
include_json_archive: true,
include_manifest: true,
include_text_archive: true,
metadata: nil,
submission: nil
}
Expand Down Expand Up @@ -75,7 +73,7 @@
describe '#run' do
subject(:run) { archive_builder_instance.run }

let(:temp_file_path) { Rails.root.join("tmp/#{benefits_intake_uuid}-random-letters-n-numbers/").to_s }
let(:temp_file_path) { Rails.root.join("tmp/#{benefits_intake_uuid}-random-letters-n-numbers-archive/").to_s }

context 'when properly initialized' do
it 'completes successfully' do
Expand Down
Loading