[10-10CG] Use CG facilities endpoint instead of hca endpoint #32038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. Hide Load more facilities button when no more exist
coope93
commented
Sep 20, 2024
| @@ -51,7 +51,7 @@ export const fetchFacilities = async ({ | |||
| }) => { | |||
| const baseUrl = `${ | |||
| environment.API_URL | |||
| }/v0/health_care_applications/facilities?type=health`; | |||
| }/v0/caregivers_assistance_claims/facilities?type=health`; | |||
There was a problem hiding this comment.
New vets-api endpoint for facilities
coope93
commented
Sep 20, 2024
| > | ||
| Load more facilities | ||
| </button> | ||
| {hasMoreFacilities() && ( |
There was a problem hiding this comment.
Only render Load more facilities button if there are more facilities to load
va-vfs-bot
temporarily deployed
to
master/70846-handle-paginated-facilities-response/main
coope93
commented
Sep 23, 2024
| @@ -67,8 +67,15 @@ export const fetchFacilities = async ({ | |||
|
|
|||
| return fetchRequest | |||
| .then(response => { | |||
| return response.map(facility => { | |||
| const { physical } = facility?.address; | |||
| if (!response?.data?.length) { | |||
There was a problem hiding this comment.
This should not really happen now, but I added logic to handle if the data object is not returned (this can happen on the backend if the pagination values are passed in out of range). If you try to send the searchbox garbage (ie search for 'my city` or something it will generally return this same response but from the mapbox api call).
coope93
commented
Sep 23, 2024
| @@ -83,12 +90,18 @@ export const fetchFacilities = async ({ | |||
|
|
|||
| // Return a new facility object with the updated address | |||
| return { | |||
| ...facility, | |||
| ...attributes, | |||
| id: facility.id, | |||
There was a problem hiding this comment.
The id is not passed in the response object attributes, so I am adding it to the response here.
coope93
commented
Sep 23, 2024
| @@ -16,7 +16,7 @@ export const setupPerTest = () => { | |||
| cy.intercept('POST', 'v0/form1010cg/attachments', mockUpload); | |||
| cy.intercept( | |||
| 'GET', | |||
| '/v0/health_care_applications/facilities?*', | |||
| '/v0/caregivers_assistance_claims/facilities?*', | |||
va-vfs-bot
temporarily deployed
to
master/70846-handle-paginated-facilities-response/main
mkerns1
previously approved these changes
Sep 23, 2024
powellkerry
previously approved these changes
Sep 23, 2024
longmd
previously approved these changes
Sep 23, 2024
coope93
dismissed stale reviews from longmd, powellkerry, and mkerns1
via
45c31a4
va-vfs-bot
temporarily deployed
to
master/70846-handle-paginated-facilities-response/main
coope93
force-pushed
the
70846-handle-paginated-facilities-response
branch
from
45c31a4
to
616d30b
Compare
longmd
approved these changes
Sep 24, 2024
powellkerry
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Load more facilitiesbutton should be loaded. The data object response is a little different format, so that is the bulk of changes in this PR.caregiver_use_facilities_API.Related issue(s)
Testing done
Screenshots
No visual changes other than
Load more facilitiesbutton is not rendered if there are no more facilities to loadWhat areas of the site does it impact?
10-10CG
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication