Expand Centralized Ecosystem Format with Language Version Information for Bundler #10867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
L: php:composer
kbukum1
changed the base branch from
main
to
kamil/update_package_manager_abstraction_for_bundler_and_composer
kbukum1
changed the title
Base automatically changed from
kamil/update_package_manager_abstraction_for_bundler_and_composer
to
main
October 31, 2024 21:07
kbukum1
force-pushed
the
kamil/add_language_info_for_bundler
branch
from
2081402
to
98cf02d
Compare
kbukum1
force-pushed
the
kamil/add_language_info_for_bundler
branch
from
98cf02d
to
301a5af
Compare
kbukum1
commented
Nov 4, 2024
| return bundler_version if package_manager.unsupported? | ||
|
|
||
| # read raw version directly from the ecosystem environment | ||
| bundler_raw_version = SharedHelpers.in_a_temporary_repo_directory( |
There was a problem hiding this comment.
Review Tip: When retrieving the full raw version of Bundler, note that if an unsupported Bundler version (e.g., "1") is specified, retrieving the raw version won’t be possible. In such cases, an "unsupported version" is getting raised error so we won't need to fetch the raw version.
kbukum1
commented
Nov 4, 2024
| def ruby_raw_version | ||
| return @ruby_raw_version if defined?(@ruby_raw_version) | ||
|
|
||
| ruby_raw_version = SharedHelpers.in_a_temporary_repo_directory( |
There was a problem hiding this comment.
Review Tip: We want to find the raw version for language directly from the ecosystem environment.
kbukum1
commented
Nov 4, 2024
|
|
||
| return nil unless package_manager.unsupported? | ||
|
|
||
| Language.new(ruby_raw_version) |
There was a problem hiding this comment.
Review Tip: If the package manager is unsupported, the language version may not be retrievable. Additionally, fetching the language version is unnecessary, as the process will raise an unsupported package manager error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR adds language version details for Bundler into the centralized ecosystem structure in Dependabot. The goal is to enhance consistency in representing package manager and language information across ecosystems.
Anything you want to highlight for special attention from reviewers?
This update follows the existing centralized format and extends it to include language versions for Bundler, laying the groundwork for other ecosystems like Composer and npm_and_yarn.
How will you know you've accomplished your goal?
Checklist