Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cython from 0.29.34 to 3.0.0 in /python/helpers #7586

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Bump cython from 0.29.34 to 3.0.0 in /python/helpers #7586

merged 2 commits into from
Aug 3, 2023

Commits on Aug 3, 2023

  1. Bump cython from 0.29.34 to 3.0.0 in /python/helpers 

    Bumps [cython](https://github.com/cython/cython) from 0.29.34 to 3.0.0.
- [Release notes](https://github.com/cython/cython/releases)
- [Changelog](https://github.com/cython/cython/blob/master/CHANGES.rst)
- [Commits](cython/cython@0.29.34...3.0.0)

---
updated-dependencies:
- dependency-name: cython
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot @jeffwidman
    dependabot[bot] authored and jeffwidman committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    59bb7fb View commit details
    Browse the repository at this point in the history

  2. Workaround pyyaml / cython incompatibility 

    This test was failing when it tried to install `pyyaml`:
```
rspec ./spec/dependabot/python/update_checker/pip_compile_version_resolver_spec.rb:139
```

The underlying issue is `PyYAML` isn't yet compatible with `cython` `3.0.0`.
So manually I bumped the `pyyaml` pin to `6.0.1` which includes a
holdback pin to not install the latest `cython`:
* yaml/pyyaml@c42fa3b

The better way to fix this would be to regenerate the `pip-compile`
output lockfile, but I wasn't sure I'd be able to do that since the
`imports_shared.in` file includes a recursive reference to another
requirements file... and that other requirements file doesn't appear to
exist on disk in the fixtures... from a quick glance at the test specs
code, it may dynamically generate that file. So I'd have to start it,
then drop into a debugger to pause it, then manually go look at the file
(if it's even saved to disk), and then re-run it... and even then, it
may cause other failures with the test since it updates all the other
versions...

Anyway, rather than tracking all that down, I merely tried the pin, and
low and behold it fixed the test. So I think we're good for now,
especially as `pyyaml` isn't part of the test at all, it's just a
transitive dep of the actual package under test.
    @jeffwidman
    jeffwidman committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    0a8e0b4 View commit details
    Browse the repository at this point in the history