-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cython from 0.29.34 to 3.0.0 in /python/helpers #7586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
added
dependencies
python
Dependabot pull requests that update Python code
labels
Jul 18, 2023
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/pip/python/helpers/cython-3.0.0
branch
2 times, most recently
from
August 3, 2023 07:37
a2ad80a
to
b591a77
Compare
jeffwidman
added
Ecosystems
Used by the maintainer team for internal-facing project tracking
and removed
dependencies
python
Dependabot pull requests that update Python code
labels
Aug 3, 2023
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/pip/python/helpers/cython-3.0.0
branch
from
August 3, 2023 18:42
b591a77
to
768349d
Compare
jeffwidman
approved these changes
Aug 3, 2023
Bumps [cython](https://github.com/cython/cython) from 0.29.34 to 3.0.0. - [Release notes](https://github.com/cython/cython/releases) - [Changelog](https://github.com/cython/cython/blob/master/CHANGES.rst) - [Commits](cython/cython@0.29.34...3.0.0) --- updated-dependencies: - dependency-name: cython dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This test was failing when it tried to install `pyyaml`: ``` rspec ./spec/dependabot/python/update_checker/pip_compile_version_resolver_spec.rb:139 ``` The underlying issue is `PyYAML` isn't yet compatible with `cython` `3.0.0`. So manually I bumped the `pyyaml` pin to `6.0.1` which includes a holdback pin to not install the latest `cython`: * yaml/pyyaml@c42fa3b The better way to fix this would be to regenerate the `pip-compile` output lockfile, but I wasn't sure I'd be able to do that since the `imports_shared.in` file includes a recursive reference to another requirements file... and that other requirements file doesn't appear to exist on disk in the fixtures... from a quick glance at the test specs code, it may dynamically generate that file. So I'd have to start it, then drop into a debugger to pause it, then manually go look at the file (if it's even saved to disk), and then re-run it... and even then, it may cause other failures with the test since it updates all the other versions... Anyway, rather than tracking all that down, I merely tried the pin, and low and behold it fixed the test. So I think we're good for now, especially as `pyyaml` isn't part of the test at all, it's just a transitive dep of the actual package under test.
jeffwidman
force-pushed
the
dependabot/pip/python/helpers/cython-3.0.0
branch
from
August 3, 2023 20:35
91dd245
to
0a8e0b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps cython from 0.29.34 to 3.0.0.
Changelog
Sourced from cython's changelog.
... (truncated)
Commits
2f3a781
Prepare release of Cython 3.0.0.ac4f0bb
Update changelog.039ef7c
In Py2, the extension type might get cleaned up before the objects at system ...8edd90a
Prepare second release candidate 3.0.0rc2.7efee97
Update changelog.c0a3556
Test including "complex.h" in MSVC (#5527)36a3702
Write the version to stderr as before, but only if stderr is actually capture...8169009
Update changelog and version.864e563
Support hex constants in enums (GH-5525)0c6141a
Document@cython
.with_gil (GH-5522)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)