Fix multiple pip compile errors #8189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-multiple-pip-compile-errors
branch
from
70c1eed to
bb3398a
Compare
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-multiple-pip-compile-errors
branch
from
bb3398a to
ca2d2f5
Compare
jakecoffman
approved these changes
Oct 13, 2023
This is used to retry without build isolation, but the message has changed in recent pip versions and was no longer matched. Now, at least in some cases, the error reads like this: ``` pip._internal.exceptions.InstallationSubprocessError: Getting requirements to build wheel exited with 1 ```
The convention is that those always perform some work.
Move the handling to wrap the only code that can raise those errors.
… updater Otherwise, retries will never succeed since even if the checker manages to find a target version to update to, the updater will fail to update the files.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-multiple-pip-compile-errors
branch
from
ca2d2f5 to
450aa61
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/fix-multiple-pip-compile-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few different bug fixes and refactorings.
I decided to propose them together, because the failing cases I was working with did not get fixed by applying only a subset of the fixes, but they need all of them to start creating sane PRs.
Break up of the different fixes is:
pip-compilewith--no-build-isolation. This error was caused by Pip itself changing the error message, and just catches up with the change. 500455f--no-build-isolationretry code into the file updater. Normally error detection only needs to happen in the update checker, since we fail early when detecting these errors and we don't need to check again in the file updater. We don't reach that far. However, in the case of these retries, if we succeed when retying, we keep going and need the same fallback when updating files. This could be improved by passing around whether--no-build-isolationneeds to be used or not from the update checker to the file updater, but for now I just copied the code to detect it. f4fa838fe5dd70aa2ed5eb5097a8f3990a80f9b2PyYAML < 6is incompatible withCython 3, which we use since last July. In that PR, this problem was actually surfaced by our specs, but we failed to notice that it was not a specs-only problem where we could upgrade ourselves to PyYAML 6, but a real world user issue. Generally we don't introduce this kind of workaround but in this case I believe it's very wide spread so it's worth introducing it and paying the cost of maintaining this extra code. bb3398a64624f29af16072c48385b8f7f4964496This is a reproducible example being fixed by this PR: