Update poetry test of oldest supported python version to 3.8
#7691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test ensures that the installed version of `poetry` works as expected with the oldest version of python currently supported by Dependabot. It (hopefully) prevents us from installing newer poetry versions that don't have support for older python versions. In just a couple of weeks we will be deprecating Python 3.6/3.7... So 3.8 will become the oldest version of Python supported by Dependabot. So update the test accordingly. To update I ran the following commands: ```shell bin/docker-dev-shell python pyenv install 3.8.17 # matches the version available to be installed from the `python/Dockerfile` PYENV_VERSION=3.8.17 pyenv exec pip install --upgrade pip PYENV_VERSION=3.8.17 pyenv exec pip install poetry PYENV_VERSION=3.8.17 pyenv exec poetry lock --no-update ```
abdulapopoola
approved these changes
Aug 1, 2023
jeffwidman
added
L: elixir:hex
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
…dabot#7691) This test ensures that the installed version of `poetry` works as expected with the oldest version of python currently supported by Dependabot. It (hopefully) prevents us from installing newer poetry versions that don't have support for older python versions. In just a couple of weeks we will be deprecating Python 3.6/3.7... So 3.8 will become the oldest version of Python supported by Dependabot. So update the test accordingly. To update I ran the following commands: ```shell bin/docker-dev-shell python pyenv install 3.8.17 # matches the version available to be installed from the `python/Dockerfile` PYENV_VERSION=3.8.17 pyenv exec pip install --upgrade pip PYENV_VERSION=3.8.17 pyenv exec pip install poetry PYENV_VERSION=3.8.17 pyenv exec poetry lock --no-update ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test ensures that the installed version of
poetryworks as expected with the oldest version of python currently supported by Dependabot. It (hopefully) prevents us from installing newer poetry versions that don't have support for older python versions.In just a couple of weeks we will be deprecating Python 3.6/3.7... So 3.8 will become the oldest version of Python supported by Dependabot.
So update the test accordingly.
To update I ran the following commands:
Related:
python3.6#7610While we can't merge the PR's officially dropping support, we are safe to merge this PR now as it only updates the tests, assuming we're okay with remembering we can't actually bump the minimum
poetryversion within the next two weeks. I hope that's a reasonable assumption given that I'll be the guy doing the actual bumping. 😁