Use dockerignore rules that play better with recent docker versions #7713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honeyankit
approved these changes
Aug 3, 2023
jeffwidman
approved these changes
Aug 3, 2023
|
This should fix Bundler's CI, currently broken due to the recent upgrade of the docker client in Actions base image. |
Apparently new versions on Docker (at least on v23) no longer include Gemfile.lock files inside `bundler/spec/fixtures` in the build image. Reading our current `.dockerignore`, it seems that the new behaviour prioritizes more explicit rules (not ending with `*`) even if they appear earlier in the file. I'm not sure if this is expected, or a bug, but we can change the entries to not be ambiguous and simplify them.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-bundler-ci
branch
from
3dd9938
to
c1871e6
Compare
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
…ix-bundler-ci Use dockerignore rules that play better with recent docker versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently new versions on Docker (at least on v23) no longer include Gemfile.lock files inside
bundler/spec/fixturesin the build image.Reading our current
.dockerignore, it seems that the new behaviour prioritizes more explicit rules (not ending with*) even if they appear earlier in the file.I'm not sure if this is expected, or a bug, but we can change the entries to not be ambiguous and simplify them.