Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dockerignore rules that play better with recent docker versions #7713

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Use dockerignore rules that play better with recent docker versions #7713

merged 2 commits into from
Aug 3, 2023

Commits on Aug 3, 2023

  1. Use dockerignore rules that play better with recent docker versions 

    Apparently new versions on Docker (at least on v23) no longer include
Gemfile.lock files inside `bundler/spec/fixtures` in the build image.

Reading our current `.dockerignore`, it seems that the new behaviour
prioritizes more explicit rules (not ending with `*`) even if they appear
earlier in the file.

I'm not sure if this is expected, or a bug, but we can change the
entries to not be ambiguous and simplify them.
    @deivid-rodriguez
    deivid-rodriguez committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    6f3f362 View commit details
    Browse the repository at this point in the history

  2. Make sure changes in .dockerignore trigger a full CI

    @deivid-rodriguez
    deivid-rodriguez committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c1871e6 View commit details
    Browse the repository at this point in the history