Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: suppress "visible label in accessible name" ACT test issue #4312

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Jan 26, 2024

Temporarily suppresses the ACT mismatch described by #4311 to avoid nightly ACT test noise until we can fix the inconsistency

Reviewer note: this suppression only has any effect if you're using ACT content that we haven't yet picked up; you'll need to npm install w3c/wcag-act-rules#main (like the nightly build does) to meaningfully validate the change locally. As of 9a370b6, this can be tested without updating to main

No QA required

@dbjorge dbjorge requested a review from a team as a code owner January 26, 2024 01:55
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, this should probably pull in the latest wcag-act-rules commit. Looks like that's dc90495

@dbjorge dbjorge merged commit 751657a into develop Jan 26, 2024
22 checks passed
@dbjorge dbjorge deleted the suppress-act-visible-label-failure branch January 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants