Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(summary-name): add role=button example #4528

Merged
merged 2 commits into from
Jul 10, 2024
Merged

chore(summary-name): add role=button example #4528

merged 2 commits into from
Jul 10, 2024

Conversation

WilcoFiers
Copy link
Contributor

Closes: #3444

@WilcoFiers WilcoFiers requested a review from a team as a code owner July 8, 2024 10:16
straker
straker previously approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor copy typo, but not enough to block the pr.

@WilcoFiers @straker
Update test/integration/rules/summary-name/summary-name.html
b6073a3 
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
@WilcoFiers WilcoFiers merged commit f379c32 into develop Jul 10, 2024
21 checks passed
@WilcoFiers WilcoFiers deleted the summary-button branch July 10, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

summary[role='button'] without accessible name not reported
2 participants
@WilcoFiers @straker