Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(summary-name): add role=button example #4528

Merged
merged 2 commits into from
Jul 10, 2024
Merged

chore(summary-name): add role=button example #4528

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25ca51f
chore(summary-name): add role=button example
WilcoFiers Jul 8, 2024
b6073a3
Update test/integration/rules/summary-name/summary-name.html
WilcoFiers Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/integration/rules/summary-name/summary-name.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@
Conflict resolution gets this to be ignored
</details>

<details>
<summary id="button-role-fail" role="button"></summary>
Conflict resolution gets this to be ignored
WilcoFiers marked this conversation as resolved.
Show resolved Hide resolved
</details>

<!-- Invalid naming methods -->

<details>
Expand Down
3 changes: 2 additions & 1 deletion test/integration/rules/summary-name/summary-name.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
["#heading-role-fail"],
["#value-attr-fail"],
["#alt-attr-fail"],
["#label-elm-fail"]
["#label-elm-fail"],
["#button-role-fail"]
],
"passes": [
["#text-pass"],
Expand Down
Loading