Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sideeffect when opening modal dialog #348

Merged

Conversation

vbakke
Copy link
Contributor

@vbakke vbakke commented Jan 2, 2025

In Circular Heatmap, opening the modal dialog displaying the Activity Details, will affect this.YamlObject, and thus affect the export of generated.yaml, with an extra navigationExtras for all activities that have been opened.

The fix was to assign a shallow copy of the activity, before adding the navigationExtras.

@wurstbrot wurstbrot requested a review from 0x41head January 3, 2025 12:21
@vbakke
Copy link
Contributor Author

vbakke commented Jan 12, 2025

Any comments on this @0x41head? Are you able to reproduce the issue?

  1. Open https://dsomm.owasp.org/circular-heatmap in incognito mode
  2. Export YAML (Download edited YAML file)
  3. Open the modal activity description for Defined build process
  4. Export YAML (Download edited YAML file) again
  5. Do a diff between the two yaml files, or search for 'navigationExtras'

Copy link
Collaborator

@0x41head 0x41head left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delay in getting back to you.
I managed to replicate the issue, and your PR resolves it flawlessly!

@wurstbrot wurstbrot merged commit fd118d7 into devsecopsmaturitymodel:master Jan 13, 2025
2 checks passed
@vbakke vbakke deleted the fix/348-modal-sideeffect branch January 13, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants